Cleanup++ #1257
Merged
Cleanup++ #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts() arg The result remains the same.
It seems this is an unintended typo. However, it demonstrates a problem with the tokenize algo - it doesn't use spell corrections for tokens that are regex-classified, because this very often leads to nonsense parsing. FIXME: Use farther tokenizing classifications for tokens that are null-linked (may not be a trivial task).
|
I've been wondering how to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains typo fixes.
However, while checking for typos (this time using the
codespellcommand), I found the following sentence in thecorpus-fixesbatch that is not getting parsed:He tried but failed to acheive his goal.From its context, I guess this is not an intended typo. So I fixed it.
But since it demonstrates a problem in the current tokenization algo (issue #404) I also added two examples to
corpus-fixes.I added a FIXME in the commit because I think I know how to fix it with negligible overhead (no reparsing).