Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NI1_Time: fix for ND connector #70

Merged
merged 1 commit into from
Jun 9, 2014
Merged

Conversation

edyirdaw
Copy link
Contributor

@edyirdaw edyirdaw commented Jun 9, 2014

The different NI connectors are not handled by relex at all. It seems best to handle each NI connector such as Nif/NIt and NI*p separately.

More specifically, this fix handles

“Jane is at the daycare center every day of the week between 7 am and 7:30 am and between 16 pm and 16:30 pm.” which relex outputs previously as

_pobj(at, center)
_psubj(at, Jane)
_quantity(and, 7am)
_quantity(7:30am, and)

Now becomes

_pobj(at, center)
_psubj(at, Jane)
conj_and(between, between)
_time(pm, 16)
_time(pm, 16:30)
_time(am, 7)
_time(am, 7:30)

Expressions which require numerical modifiers such as pm, m (meters), etc need to be written with space. So, 7am won't work but 7 am does. This looks like a link-grammar issue.

The use of a time flag is deemed redundant and “_time” seems to suffice for the identification of time information.

More generally, the fix handles the use of the NI connectors with the ND connector.

Fixes for other NI connector types and their use with other types of connectors such as Dmcn are yet to be implemented.

linas added a commit that referenced this pull request Jun 9, 2014
NI1_Time: fix for ND connector
@linas linas merged commit 16b76d2 into opencog:master Jun 9, 2014
@linas
Copy link
Member

linas commented Jun 9, 2014

Nice. .. but its incomplete; there needs to be something like
_between(16, 16:30)
_between(7,7:30)

to indicate the actual ranges.

Also, can you add example sentences that trigger each of the rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants