Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The different NI connectors are not handled by relex at all. It seems best to handle each NI connector such as Nif/NIt and NI*p separately.
More specifically, this fix handles
“Jane is at the daycare center every day of the week between 7 am and 7:30 am and between 16 pm and 16:30 pm.” which relex outputs previously as
_pobj(at, center)
_psubj(at, Jane)
_quantity(and, 7am)
_quantity(7:30am, and)
Now becomes
_pobj(at, center)
_psubj(at, Jane)
conj_and(between, between)
_time(pm, 16)
_time(pm, 16:30)
_time(am, 7)
_time(am, 7:30)
Expressions which require numerical modifiers such as pm, m (meters), etc need to be written with space. So, 7am won't work but 7 am does. This looks like a link-grammar issue.
The use of a time flag is deemed redundant and “_time” seems to suffice for the identification of time information.
More generally, the fix handles the use of the NI connectors with the ND connector.
Fixes for other NI connector types and their use with other types of connectors such as Dmcn are yet to be implemented.