Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ellipsis instead of wrapping on the Profile Menu #10812

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

kewitz
Copy link
Contributor

@kewitz kewitz commented Nov 20, 2024

Resolves opencollective/opencollective#7598

An alternative could be making it a bit wider.

Preview:
image

@kewitz kewitz requested a review from Betree November 20, 2024 14:20
@kewitz kewitz self-assigned this Nov 20, 2024
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:35pm
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:35pm

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, but it's sad that we had to drop the New badge. Would be great if we can keep it.

Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
@kewitz
Copy link
Contributor Author

kewitz commented Nov 21, 2024

@Betree with the title parameter I think it is OK to keep it, wdyt?

image

@Betree
Copy link
Member

Betree commented Nov 21, 2024

@Betree with the title parameter I think it is OK to keep it, wdyt?

image

Looks perfect!

@kewitz kewitz merged commit e92d4e3 into main Nov 21, 2024
20 checks passed
@kewitz kewitz deleted the fix/profile-menu-wrapping branch November 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I18n responsiveness issues in the user menu
2 participants