Fix the Backward compatibility changes in MACSEC attribute #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
cc @dipankar-ba / @prafull-brcm please check. |
|
There is still discussion where swss need to updated to use read-only attribute going forward and there should not be use-case of doing write. Make PR as draft mode. |
kcudnik
approved these changes
Apr 3, 2021
|
Closing the PR. SONiC will need to align with new changes wr.t MACSEC attributes to use now read-only attribute cc @lguohan and @Pterosaur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did:
PR #1169 the backward compatibility of attribute
SAI_MACSEC_SA_ATTR_XPNis not handled correctly. Needed for v1.8.0How I did
Assign
SAI_MACSEC_SA_ATTR_XPNtoSAI_MACSEC_SA_ATTR_CONFIGURED_EGRESS_XPN.