Add OCI-Chunk-Min-Length header #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-dee7
reviewed
Mar 14, 2023
8 tasks
sudo-bmitch
force-pushed
the
pr-chunk-min-size
branch
2 times, most recently
from
89e6342 to
5a465f1
Compare
sudo-bmitch
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe and
vbatts
as code owners
mikebrow
reviewed
Mar 16, 2023
jdolitsky
previously approved these changes
Mar 16, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-chunk-min-size
branch
from
5a465f1 to
851ea52
Compare
sudo-bmitch
changed the title
jdolitsky
approved these changes
Mar 16, 2023
|
@jay-dee7 any concerns with the latest changes? If not, I'll merge this. |
|
@sudo-bmitch I'm super happy and excited about this change. Please merge it :) and thanks a ton for getting this done the entire OCI team ❤️ ❤️ |
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #374. It adds a new
OCI-Chunk-Min-Bytesheader on the blob POST method response. This allows the client to push chunks of at least that size, which is needed for some S3 backends.