-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Warning
header usage
#393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
reviewed
Mar 17, 2023
BenTheElder
reviewed
Mar 17, 2023
sudo-bmitch
reviewed
Mar 17, 2023
imjasonh
commented
Mar 17, 2023
BenTheElder
reviewed
Mar 17, 2023
jdolitsky
reviewed
Mar 17, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
jdolitsky
reviewed
Mar 17, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
BenTheElder
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
jdolitsky
approved these changes
Mar 17, 2023
sudo-bmitch
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonjohnsonjr
approved these changes
Mar 17, 2023
vbatts
approved these changes
Mar 19, 2023
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
This is heavily inspired by Kubernetes' support for warnings returned by the API server and surfaced by clients like
kubectl
: https://kubernetes.io/blog/2020/09/03/warnings/tl;dr: Registries MAY return informational warning messages in the
Warning
header, as described in https://www.rfc-editor.org/rfc/rfc7234#section-5.5, with the added restriction that thewarn-code
must be 299 and thewarn-agent
must be unset (-
). Clients SHOULD surface those messages to the user in an unobtrusive and helpful way -- how they do that is up to them.Blatantly cribbing further helpful advice from #390 (comment):
and from #390 (comment)
cc @BenTheElder @liggitt
@jonjohnsonjr @jdolitsky @sudo-bmitch @sajayantony