Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat "Platform Variants", especially to add amd64, ppc64le, riscv64 #1172

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 27, 2024

This changes the table to be a line per ISA instead of per variant; adds x86-64, POWER8+, and RISC-V; and notes the appropriate "Go analog" in each case (because these values mirror Go's choices, like our use of GOOS and GOARCH).

Of particular note, GOARM64 and GORISCV64 are not fully implemented or released in Go yet, but they are accepted proposals with in-progress implementations or already merged to main:

Closes #852

This changes the table to be a line per ISA instead of per variant; adds x86-64, POWER8+, and RISC-V; and notes the appropriate "Go analog" in each case (because these values mirror Go's choices, like our use of `GOOS` and `GOARCH`).

Of particular note, `GOARM64` and `GORISCV64` are not fully implemented or released in Go yet, but they are accepted proposals with in-progress implementations or already merged to main:

- `GOARM64`: https://golang.org/issue/60905
- `GORISCV64`: https://golang.org/issue/61476#issuecomment-1791156741

Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
| ARM 32-bit, v7 | `arm` | `v7` |
| ARM 32-bit, v8 | `arm` | `v8` |
| ARM 64-bit, v8 | `arm64` | `v8` |
These values SHOULD match (or be similar to) their analog listed in [the Go Language document][go-environment2].
Copy link
Member Author

@tianon tianon Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or be similar to)

This part makes me nuts, but I felt like I had to somehow address that GOARM does not use a v prefix, GOARM64 will not (at least initially) support v8 (without a minor, like v8.0), we don't do extra things like softfloat or sse2 in this field, etc SOMEHOW in this wording.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, i would be more explicit in tags that are supported. One can reference go constants as valid ones, but specify them explicitly.

There will always be variants that are not yet specified or relevant for go, but do make sense to be explicit for container images that contain code that was written in other languages. For example, whilst GOARM64 is already defined, it doesn't actually do anything different in go - but it does for gcc for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table below does include explicit examples, though 😅

@sudo-bmitch sudo-bmitch merged commit b30f6ed into opencontainers:main Mar 28, 2024
4 checks passed
@tianon tianon deleted the platform-variants branch March 28, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track amd64 variants
4 participants