annotations: addressing comments #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @amouat |
|
@vbatts The compat table is merged but I think we should rename |
stevvooe
reviewed
May 17, 2017
annotations.md
Outdated
| * **org.opencontainers.image.source** URL to get source code for the binary files in the image (string, a URL with scheme HTTP or HTTPS) | ||
| * **org.opencontainers.image.homepage** URL to find more information on the image (string) | ||
| * **org.opencontainers.image.documentation** URL to get documentation on the image (string) | ||
| * **org.opencontainers.image.source** URL to get source code for the image-build (string) | ||
| * **org.opencontainers.image.version** [Semantic versioning-compatible](http://semver.org/) version of the packaged software. |
There was a problem hiding this comment.
Can we relax semantic versioning?
AkihiroSuda
reviewed
May 18, 2017
annotations.md
Outdated
| * **org.opencontainers.image.source** URL to get source code for the binary files in the image (string, a URL with scheme HTTP or HTTPS) | ||
| * **org.opencontainers.image.homepage** URL to find more information on the image (string) | ||
| * **org.opencontainers.image.documentation** URL to get documentation on the image (string) | ||
| * **org.opencontainers.image.source** URL to get source code for the image-build (string) |
There was a problem hiding this comment.
nit: "the image-build" -> "building the image" ?
(It looks like as if it were a proper noun, actually I googled "image-build" 😆 )
AkihiroSuda
reviewed
May 18, 2017
annotations.md
Outdated
| * **org.opencontainers.image.homepage** URL to find more information on the image (string, a URL with scheme HTTP or HTTPS) | ||
| * **org.opencontainers.image.documentation** URL to get documentation on the image (string, a URL with scheme HTTP or HTTPS) | ||
| * **org.opencontainers.image.source** URL to get source code for the binary files in the image (string, a URL with scheme HTTP or HTTPS) | ||
| * **org.opencontainers.image.homepage** URL to find more information on the image (string) |
There was a problem hiding this comment.
this now image.url
https://github.com/opencontainers/image-spec/pull/676/files
vbatts
force-pushed
the
annotations_cleanup_1
branch
from
c12fd2e to
0bca862
Compare
|
updated. PTAL. |
|
@vbatts Did you want to move |
|
On Thu, May 18, 2017 at 2:29 PM Stephen Day ***@***.***> wrote:
@vbatts <https://github.com/vbatts> Did you want to move name to title,
per our discussion?
oh right. one sec.
|
From: opencontainers#658 (comment) * Source is not just to binaries. * the strings already say URL, so it's redundant * git:// is a valid URL as well * version MAY be semantic * 'name' -> 'title' Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
annotations_cleanup_1
branch
from
0bca862 to
6a427b4
Compare
|
updated. PTAL. |
|
LGTM |
|
Review please. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #658 (comment)
Signed-off-by: Vincent Batts vbatts@hashbangbash.com