Add Sajay as maintainer #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky
requested review from
brendandburns,
jonjohnsonjr,
jstarks,
jonboulle,
stevvooe,
vbatts and
cyphar
as code owners
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
|
For CI failure, see #916 |
|
rebase pls |
vbatts
approved these changes
May 13, 2022
|
I've updated the issue description to follow the new template |
|
@stevvooe @jonjohnsonjr @cyphar @jonboulle would be great to get votes up or down on this candidate for maintainer. If we have maintainers who feel they can't vote then it would be great to understand what additional information would be helpful to make a decision. Thanks! |
|
ping |
stevvooe
previously approved these changes
Aug 5, 2022
|
pong ping pongity pong pong ping ping pong |
jonboulle
previously approved these changes
Aug 10, 2022
|
As this has 2/3 quorum of current maintainers (and has been opened for at least five days), this is a go! Welcome @sajayantony! |
|
Ah, codeowners rebase needed because #909 just merged as well |
sudo-bmitch
approved these changes
Aug 10, 2022
vbatts
approved these changes
Aug 10, 2022
jonboulle
approved these changes
Aug 10, 2022
|
💚 and welcome @sudo-bmitch. |
|
💙
Sent from Yahoo Mail on Android
On Wed, Aug 10, 2022 at 12:04 PM, Sajay ***@***.***> wrote:
💚 and welcome @sudo-bmitch.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomination for a New Maintainer
Nominating Maintainer
jdolitsky
New Maintainer
sajayantony
Justification
Need 3 approvals from the current 5 maintainers: