CONTRIBUTING: Make leader-issues optional #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For small projects like ocitools a strict requirement would just be busywork. And the risk here (a submitted PR that would have been rejected or redirected in a leader issue) is a risk assumed by the submitter (who sunk time in the wrong direction) and not much cost to the maintainers. Signed-off-by: W. Trevor King <wking@tremily.us>
|
Although for runtime-spec there is a leader-thread requirement for discussion. It's not always respected, but the idea is to spread awareness of significant changes to folks who may not be watching the repositories closely (Go docs referenced from here). That's a different goal than saving contributor time, and may deserve some kind of wording in this CONTRIBUTING file. |
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Jan 6, 2017
Extending the earlier softening in 0548361 (CONTRIBUTING: Make leader-issues optional, 2016-05-19, opencontainers#6), because nobody cares about the XXX- prefix. Checking the recent history of all OCI project repos: $ for REPO in image-spec image-tools runc runtime-spec runtime-tools; > do > ( > cd "${REPO} && > git fetch origin && > BRANCHES=$(git log --first-parent --oneline origin/master | sed 's/^.* from //') && > echo "${REPO} branches: $(echo "${BRANCHES}" | wc -l)" && > echo "${REPO} numbered: $(echo "${BRANCHES}" | grep '/[0-9]' | wc -l)" > ); > done image-spec branches: 276 image-spec numbered: 1 image-tools branches: 27 image-tools numbered: 0 runc branches: 1299 runc numbered: 21 runtime-spec branches: 391 runtime-spec numbered: 4 runtime-tools branches: 232 runtime-tools numbered: 3 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Jan 6, 2017
Extending the earlier softening in 0548361 (CONTRIBUTING: Make leader-issues optional, 2016-05-19, opencontainers#6), because nobody cares about the XXX- prefix. Checking the recent history of all OCI project repos: $ for REPO in image-spec image-tools runc runtime-spec runtime-tools; > do > ( > cd "${REPO} && > git fetch origin && > BRANCHES=$(git log --first-parent --oneline origin/master | sed 's/^.* from //') && > echo "${REPO} branches: $(echo "${BRANCHES}" | wc -l)" && > echo "${REPO} numbered: $(echo "${BRANCHES}" | grep '/[0-9]' | wc -l)" > ); > done image-spec branches: 276 image-spec numbered: 1 image-tools branches: 27 image-tools numbered: 0 runc branches: 1299 runc numbered: 21 runtime-spec branches: 391 runtime-spec numbered: 4 runtime-tools branches: 232 runtime-tools numbered: 3 Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For small projects like ocitools a strict requirement would just be
busywork. And the risk here (a submitted PR that would have been
rejected or redirected in a leader issue) is a risk assumed by the
submitter (who sunk time in the wrong direction) and not much cost to
the maintainers.
Addresses my ocitools comment.