Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use Dockerfile for build #93

Closed
hqhq opened this issue Jul 7, 2015 · 6 comments
Closed

Why not use Dockerfile for build #93

hqhq opened this issue Jul 7, 2015 · 6 comments

Comments

@hqhq
Copy link
Contributor

hqhq commented Jul 7, 2015

I see there are several build issues, myself met build issues too, I wonder why we don't use Dockerfile to setup an unified environment for building?

I thought runc was considered as an independent project which won't depend on Docker or other projects, but then I see we still use Docker for test, so I think we can use Docker for build as well.

Is there any specific reasons why we don't use Dockerfile? Thanks.

@kgrvamsi
Copy link

kgrvamsi commented Jul 7, 2015

Can you send the output log of the build issue you got?

@hqhq
Copy link
Contributor Author

hqhq commented Jul 7, 2015

I got:

$ make
go build -o runc .
# github.com/opencontainers/runc/libcontainer/seccomp
libcontainer/seccomp/seccomp.go:71: internal compiler error: unknown etype 0/STRUCT
make: *** [all] Error 2

I think it's because my golang is too old:

$ go version
go version go1.2.1 linux/amd64

Now I'm using dockercore/libcontainer image to build and test runc. It works perfectly.

@kgrvamsi
Copy link

kgrvamsi commented Jul 7, 2015

ya its because of the old golang version and faced the same issue and when i changed it to 1.4 then i dont see this issue any where.Try using gvm when your facing issues like this so that u can change ur golang versions anytime

@kgrvamsi
Copy link

kgrvamsi commented Jul 7, 2015

I think there is already a dockerfile in the repo dont know if it is useful for you

https://github.com/opencontainers/runc/blob/master/test_Dockerfile

@crosbymichael
Copy link
Member

No reason, we can add one if you want ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants