Fix checkpoint/restore tests with newer kernel #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates criu to the latest release to help resolve some of the issues we are seeing on the CI. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
print out errors in checkpoint/restore log when it failed similar to how we did i in `checkpoint --pre-dump` tests Signed-off-by: Daniel Dao <dqminh89@gmail.com>
CI has fixed kernel version for stack gap bug, updated to xemul/criu@3ca8e57 which seems to fix the failed tests. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
|
This also probably should replace #1483 |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story for the stack gap problem: https://github.com/xemul/criu/issues/322
This upgrades criu to a testing commit to fix our test failures. We should upgrade again when criu does a release but this commit seems to fix the tests for now.