Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more test case for CleanPath #1892

Merged
merged 1 commit into from
Sep 17, 2018
Merged

test: add more test case for CleanPath #1892

merged 1 commit into from
Sep 17, 2018

Conversation

Ace-Tang
Copy link
Contributor

Signed-off-by: Ace-Tang aceapril@126.com

what I do

add more test case for libcontainer/utils.CleanPath.

@Ace-Tang
test: add more test case for CleanPath
5963cf2 
Signed-off-by: Ace-Tang <aceapril@126.com>
@Ace-Tang
Copy link
Contributor Author

Hi, @cyphar , I think CleanPath miss some test case like /foo/bar/, /foo/bar/../.

@cyphar
Copy link
Member

cyphar commented Sep 14, 2018 •
edited by caniszczyk
Loading

LGTM.

Approved with PullApprove

@crosbymichael
Copy link
Member

crosbymichael commented Sep 17, 2018 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit d77251d into opencontainers:master Sep 17, 2018
@Ace-Tang Ace-Tang deleted the add_clean_test branch September 18, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ace-Tang @cyphar @crosbymichael