Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc94 regression] libct/cg/sd: fix dbus error handling #2997

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jun 3, 2021

This fixes isDbusError function, introduced by commit bacfc2c. Due to a
type error it was not working at all.

This also fixes the whole "retry on dbus disconnect" logic, introduced
in PR #2923. Most probably it was not working at all before this fix.

This also fixes a regression in startUnit (and cgroupManager.Apply()),
which should never return "unit already exists" error but it did (#2996).

A test case is added to check that the last issue is fixed.

Fixes: bacfc2c
Fixes: #2996
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1941456
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1965545

Proposed changelog entry

  • cgroups/systemd: fixed "retry on dbus disconnect" logic introduced in rc94
  • cgroups/systemd: fixed returning "unit already exists" error from a systemd cgroup manager (regression in rc94)

This fixes isDbusError function, introduced by commit bacfc2c. Due to a
type error it was not working at all.

This also fixes the whole "retry on dbus disconnect" logic.

This also fixes a regression in startUnit (and cgroupManager.Apply()),
which should never return "unit already exists" error but it did.

Fixes: bacfc2c
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemd "unit already exists" error is not ignored during startUnit
3 participants