Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct/intelrdt: explain why mountinfo is required #3339

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

kolyshkin
Copy link
Contributor

For the Nth time I wanted to replace parsing mountinfo with
statfs and the check for superblock magic, but it is not possible
since some code relies of mount options check which can only
be obtained via mountinfo.

Add a note about it.

Currently a draft, pending #3306 merge.

@thaJeztah
Copy link
Member

#3306 was merged; looks like this can be rebased and moved out of draft

For the Nth time I wanted to replace parsing mountinfo with
statfs and the check for superblock magic, but it is not possible
since some code relies of mount options check which can only
be obtained via mountinfo.

Add a note about it.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin force-pushed the rtd-faster-followup branch from f585d4f to 5e201e7 Compare January 20, 2022 18:37
@kolyshkin kolyshkin marked this pull request as ready for review January 20, 2022 18:37
@kolyshkin
Copy link
Contributor Author

rebased; no longer a draft

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit a2805a3 into opencontainers:master Jan 24, 2022
@kolyshkin kolyshkin mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants