Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct: Mount: rm {Pre,Post}mountCmds #3350

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

kolyshkin
Copy link
Contributor

Those were added by commit 59c5c3a back in Apr 2015, but AFAICS were
never used and are obsoleted by more generic container hooks (initially
added by commit 05567f2 in Sep 2015).

Those were added by commit 59c5c3a back in Apr 2015, but AFAICS were
never used and are obsoleted by more generic container hooks (initially
added by commit 05567f2 in Sep 2015).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

@rhatdan PTAL

@kolyshkin
Copy link
Contributor Author

centos-stream-8 failure:

=== RUN   TestPodSkipDevicesUpdate
    systemd_test.go:104: open /sys/fs/cgroup/cpuset/system.slice/system-runc_test_podTestPodSkipDevicesUpdate.slice/cpuset.cpus: no such file or directory
--- FAIL: TestPodSkipDevicesUpdate (0.07s)

I have not seen it before. Filed #3351, CI job restarted.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably we should document this in the change log, although nobody is likely using libcontainer directly today.

@thaJeztah
Copy link
Member

Also did a quick search, and only found two occurrences of this being used;

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

I'll go ahead and merge, but feel free to comment if there are concerns in removing this

@thaJeztah thaJeztah merged commit 7173c53 into opencontainers:main Feb 3, 2022
@cyphar cyphar mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants