Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump github.com/checkpoint-restore/go-criu to 6.3.0 #3652

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

rst0git
Copy link
Contributor

@rst0git rst0git commented Nov 1, 2022

This pull request updates go-criu to version 6.3.0. In this version we introduced the rpc and stats components from v5 for backwards compatibility. This change prevents unnecessary increase (~2 MiB) of the compiled binary file due to the auto-generated protobuf bindings included with crit.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit c393d16 into opencontainers:main Nov 2, 2022
@kolyshkin
Copy link
Contributor

Wow, almost 11% of code+data+bss size shaved off by this PR, thanks @rst0git !

text     data     bss     dec       hex     filename
5688155  3682200  230024  9600379   927d7b  runc
6134459  4449120  236488  10820067  a519e3  runc.before-go-criu-bump

@kolyshkin kolyshkin added this to the 1.2.0 milestone Nov 2, 2022
@rst0git rst0git deleted the deps-go-criu branch November 2, 2022 16:28
@cyphar cyphar mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants