Add support for umask when exec container

[Wang-squirrel]

Signed-off-by: Wang-squirrel wang.xiaosong1@zte.com.cn

[ningmingxiao]

this will support update umask when exec container @kolyshkin

[kolyshkin]

this will support update umask when exec container @kolyshkin

Thanks! Need to fix a linter warning (please use gofumpt), and add a test case.

For the test case, something like this should work:

diff --git a/tests/integration/umask.bats b/tests/integration/umask.bats
index fe9f9d63..38e8f621 100644
--- a/tests/integration/umask.bats
+++ b/tests/integration/umask.bats
@@ -21,4 +21,9 @@ function teardown() {
        [ "$status" -eq 0 ]
        # umask 63 decimal = umask 77 octal
        [[ "${output}" == *"77"* ]]
+
+       runc exec test_busybox grep '^Umask:' "/proc/self/status"
+       [ "$status" -eq 0 ]
+       # umask 63 decimal = umask 77 octal
+       [[ "${output}" == *"77"* ]]

[Wang-squirrel]

@kolyshkin done

[Wang-squirrel]

Please check it, thanks @kolyshkin @AkihiroSuda

[AkihiroSuda]

shfmt is failing
https://github.com/opencontainers/runc/actions/runs/3545124237/jobs/5984445102

[Wang-squirrel]

shfmt is failing https://github.com/opencontainers/runc/actions/runs/3545124237/jobs/5984445102

done it

[kolyshkin]

LGTM

[AkihiroSuda]

LGTM but slightly fear this may potentially break some compatibility

[kolyshkin]

LGTM but slightly fear this may potentially break some compatibility

I guess we can afford it with 1.2.0. I checked and it looks like crun is supporting umask for exec from the very beginning.

[kolyshkin]

@Wang-squirrel can you please rebase?

[Wang-squirrel]

@Wang-squirrel can you please rebase?

Done

[kolyshkin]

still LGTM