Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specconv: avoid mapping "acl" to MS_POSIXACL #3739

Merged
merged 1 commit into from
Mar 20, 2023
Merged

specconv: avoid mapping "acl" to MS_POSIXACL #3739

merged 1 commit into from
Mar 20, 2023

Conversation

AkihiroSuda
Copy link
Member

From torvalds/linux@caaef1b :

In fact SB_POSIXACL is an internal flag, and accepting MS_POSIXACL on
the mount(2) interface is possibly a bug.

Fix #3738

kolyshkin
kolyshkin previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe it makes sense to add a comment saying that we do not map "acl/noacl" to unix.MS_POSIXACL as Linux kernel does not support it (or just link to #3738). This way, the flag/option won't be re-added by someone.

@AkihiroSuda
specconv: avoid mapping "acl" to MS_POSIXACL
92a4ccb 
From torvalds/linux@caaef1b :

> In fact SB_POSIXACL is an internal flag, and accepting MS_POSIXACL on
> the mount(2) interface is possibly a bug.

Fix issue 3738

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Maybe it makes sense to add a comment saying that we do not map "acl/noacl" to unix.MS_POSIXACL as Linux kernel does not support it (or just link to #3738). This way, the flag/option won't be re-added by someone.

done

kolyshkin
kolyshkin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the 1.2.0 milestone Feb 16, 2023
@AkihiroSuda AkihiroSuda requested a review from a team February 28, 2023 00:22
@kolyshkin
Copy link
Contributor

@opencontainers/runc-maintainers PTAL

@kolyshkin kolyshkin merged commit e67dc39 into opencontainers:main Mar 20, 2023
@cyphar cyphar mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

mount: acl implementation is probably wrong
3 participants
@AkihiroSuda @kolyshkin @mrunalp