libct/cg/sd: use systemd v240+ new MAJOR:* syntax #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
skip-proc-devices
branch
from
e2bfa95
to
64b9f6b
Compare
Merged
kolyshkin
force-pushed
the
skip-proc-devices
branch
from
64b9f6b
to
b3dc4ce
Compare
kolyshkin
force-pushed
the
skip-proc-devices
branch
from
b3dc4ce
to
26322bc
Compare
|
@opencontainers/runc-maintainers PTAL |
AkihiroSuda
approved these changes
May 11, 2023
|
@opencontainers/runc-maintainers PTAL |
|
rebased |
kolyshkin
force-pushed
the
skip-proc-devices
branch
from
26322bc
to
46dadfb
Compare
|
@lifubang PTAL |
Since systemd v240 (commit 8e8b5d2e6d91180a), one can use
/dev/{char,block}-MAJOR syntax to specify that all MAJOR:*
devices are allowed.
Use it, if available, since it's more straightforward, plus
we can skip somewhat expensive parsing of /proc/devices.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
force-pushed
the
skip-proc-devices
branch
from
46dadfb
to
701dff7
Compare
lifubang
approved these changes
Jul 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since systemd v240 (systemd commit 8e8b5d2e6d91180a), one can use
/dev/{char,block}-MAJORsyntax to specify that allMAJOR:*devices of the type are allowed.
Use it, if available, since it's more straightforward, plus
we can skip somewhat expensive parsing of /proc/devices
(which also reminds me we need to merge #3357).