[1.1] features: Fix ociMaxVersion #3989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are vendoring a runtime-spec version that breaks semver. Let's just hardcode the ociMaxVersion, instead of using the version from the bindings that reports "1.0.2-dev", that should be interpreted as something bigger than "1.0.2". That is not true according to semver, so let's just report "1.0.3-dev" that is indeed bigger according to semver. We don't expect to change the runtime-spec vendored version in the 1.1 release. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
rata
force-pushed
the
rata/fix-features-version
branch
from
9baadd1 to
1affd25
Compare
|
How about we resolve the issue in the spec first? 😺 |
cyphar
requested changes
Aug 22, 2023
There was a problem hiding this comment.
NACK, for the reasons I outlined in opencontainers/runtime-spec#1220 and opencontainers/runtime-spec#1221. If we decide to change how we do versions in the specs, we can revisit this.
I also generally don't like faking versions. umoci has to do this because the OCI spec verification tools don't handle unknown versions properly (and the +dev change was explicitly done in order to make this easier and remove the need for fake spec versions). I don't want runc to do this at all if possible.
|
Closing for the same info state: opencontainers/runtime-spec#1220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are vendoring a runtime-spec version that breaks semver. Let's just hardcode the ociMaxVersion, instead of using the version from the bindings that reports "1.0.2-dev", that should be interpreted as something bigger than "1.0.2".
That is not true according to semver, so let's just report "1.0.3-dev" that is indeed bigger according to semver. We don't expect to change the runtime-spec vendored version in the 1.1 release.
For more info, see: opencontainers/runtime-spec#1220
cc @AkihiroSuda