Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: Expose idmap support #3993

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

rata
Copy link
Member

@rata rata commented Aug 23, 2023

This PR just exposes the idmap support in the "features" subcommand.

cc @cyphar @AkihiroSuda

Future commits will expose this info in the features sub-command.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@rata rata force-pushed the rata/features-expose-idmap branch from 2804558 to 05c6d7e Compare August 23, 2023 14:17
@rata
Copy link
Member Author

rata commented Aug 23, 2023

Hmm the features subcommand seems to fail on rootless, but I can't repro locally. Any ideas?

@rata rata force-pushed the rata/features-expose-idmap branch from f14a893 to 4884689 Compare August 23, 2023 14:44
@rata
Copy link
Member Author

rata commented Aug 23, 2023

Should be fixed now. I did the same we are doing in help.bats :)

@rata
Copy link
Member Author

rata commented Aug 23, 2023

Can someone add the changelog impact labels?

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(nb)

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@rata rata force-pushed the rata/features-expose-idmap branch from 4884689 to cc7e607 Compare August 23, 2023 15:55
@rata rata requested a review from AkihiroSuda August 23, 2023 16:03
@rata
Copy link
Member Author

rata commented Aug 23, 2023

@AkihiroSuda fixed, PTAL :)

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyphar cyphar merged commit 693d1c6 into opencontainers:main Aug 23, 2023
36 checks passed
@rata rata deleted the rata/features-expose-idmap branch September 5, 2023 14:22
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 3, 2023
19 tasks
@cyphar cyphar mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants