-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate libcontainer/user, and migrate to github.com/moby/sys/user #4017
Deprecate libcontainer/user, and migrate to github.com/moby/sys/user #4017
Conversation
thaJeztah
commented
Sep 16, 2023
•
edited
Loading
edited
- addresses RFC: remove user/group name support from libcontainer #3998
- depends on integrate github.com/opencontainers/runc/libcontainer/user (alternative) moby/sys#134
113f508
to
fe1bc09
Compare
@opencontainers/runc-maintainers PTAL I didn't tag a version yet, pending if we're all in agreement 😃 (I split this PR into two commits, so that we can potentially cherry-pick the first one into existing release branches). |
go.mod
Outdated
@@ -11,6 +11,7 @@ require ( | |||
github.com/docker/go-units v0.5.0 | |||
github.com/godbus/dbus/v5 v5.1.0 | |||
github.com/moby/sys/mountinfo v0.6.2 | |||
github.com/moby/sys/user v0.0.0-20230918201840-c0711cde08c8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a tag?
Yes, we can, but I wanted to be sure we were all in agreement (I want this to be a "move" of a package, and not ending up with a (friendly) fork) 😅 #4017 (comment)
Here's what I'm proposing;
Perhaps there's some more cleaning up to do, so I didn't want to move straight on to v1.0.0. SemVer recommendation is to start at |
I'll have a look at the linting failures (I guess it complains because it's considering it "new code" now) Also: I'm more than happy to add additional runc maintainers as maintainer on moby/sys, if people want to participate in maintaining that code-base (as it has modules that are common among various projects). |
fe1bc09
to
d322edd
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d322edd
to
d9ea71b
Compare
Tagged a v0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks! I'll also have a look at fixing the CameCase nits in moby/sys (for a v0.2.0, or whatever version it will be); for this one I wanted it to be a clean "move" |