[1.1] runc list: fix race with runc delete #4231

kolyshkin · 2024-03-27T05:00:02Z

This is a backport of #3349 to release-1.1. Original description follows.

It is possible that parallel execution of runc list with runc delete will result in runc list fatal failure. Fix this.

Bonus: some refactoring.

Please review with --ignore-all-space ("Hide whitespace" checked on GH).

lifubang · 2024-03-28T01:28:40Z

I think we should also change the go version to 1.21 in github workflow definition file because of #4193.
But I'm curious about why there is no failure in the main branch.

Setup go version spec 1.x
Found in cache @ /opt/hostedtoolcache/go/1.22.1/x64
Added go to the path
Successfully set up Go version 1.x
/opt/hostedtoolcache/go/1.22.1/x64/bin/go env GOMODCACHE
/opt/hostedtoolcache/go/1.22.1/x64/bin/go env GOCACHE
/home/runner/go/pkg/mod
/home/runner/.cache/go-build
Cache is not found
go version go1.22.1 linux/amd64

kolyshkin · 2024-03-28T01:46:57Z

I think we should also change the go version to 1.21 in github workflow definition file because of #4193.

Yes, done.

But I'm curious about why there is no failure in the main branch.

I see that for cross-386 job we use Ubuntu 22.04 in main and 20.04 here, plus we only run unit tests (for some reason unit tests do not fail in 22.04 with Go 1.22, I guess we use nsenter in a slightly different manner).

Hmm.

kolyshkin · 2024-03-28T01:48:33Z

I see that for cross-386 job we use Ubuntu 22.04 in main and 20.04 here, plus we only run unit tests (for some reason unit tests do not fail in 22.04 with Go 1.22, I guess we use nsenter in a slightly different manner).

Ah, nevermind, Ubuntu 22.04 fails for different reason (spec validator test, see here) and its glibc seems to be fine wrt Go 1.22 issue.

lifubang · 2024-03-30T16:46:12Z

Please see 6fb24a2 in #4193 , I think maybe we can resolve this clone(2) issue. Please help to see what's wrong with the remain failure test cases.

medyagh · 2024-04-09T21:45:33Z

we look forward to use this PR once it is included in the release in minikube, currently causing integration test failures

lifubang

still LGTM

Instead of a huge if {} block, use continue. Best reviewed with --ignore-all-space. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 095929b) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Since commit 5516294 we can (and should) use Info() to get access to file stat. Do this. While going over directory entries, a parallel runc delete can remove an entry, and with the current code it results in a fatal error (which was not observed in practice, but looks quite possible). To fix, add a special case to continue on ErrNotExist. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 1a3ee49) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

v1.1.13 -- "There is no certainty in the world. This is the only certainty I have." This is the thirteenth patch release in the 1.1.z release branch of runc. It brings in Go 1.12.x compatibility and fixes a few issues, including an occasional wrong nofile rlimit in runc exec, and a race between runc list and runc delete. NOTE that if using Go 1.22.x to build runc, make sure to use 1.22.4 or a later version. For more details, see issue opencontainers#4233. * Support go 1.22.4+. (opencontainers#4313) * runc list: fix race with runc delete. (opencontainers#4231) * Fix set nofile rlimit error. (opencontainers#4277, opencontainers#4299) * libct/cg/fs: fix setting rt_period vs rt_runtime. (opencontainers#4284) * Fix a debug msg for user ns in nsexec. (opencontainers#4315) * script/*: fix gpg usage wrt keyboxd. (opencontainers#4316) * CI fixes and misc backports. (opencontainers#4241) * Fix codespell warnings. (opencontainers#4300) * Silence security false positives from golang/net. (opencontainers#4244) * libcontainer: allow containers to make apps think fips is enabled/disabled for testing. (opencontainers#4257) * allow overriding VERSION value in Makefile. (opencontainers#4270) * Vagrantfile.fedora: bump Fedora to 39. (opencontainers#4261) * ci/cirrus: rm centos stream 8. (opencontainers#4305, opencontainers#4308) Thanks to all of the contributors who made this release possible: * Akhil Mohan <akhilerm@gmail.com> * Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> * Aleksa Sarai <cyphar@cyphar.com> * Kir Kolyshkin <kolyshkin@gmail.com> * Sohan Kunkerkar <sohank2602@gmail.com> * TTFISH <jiongchiyu@gmail.com> * kychen <kychen@alauda.io> * lifubang <lifubang@acmcoder.com> * ls-ggg <335814617@qq.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> # -----BEGIN PGP SIGNATURE----- # # iQEzBAABCAAdFiEEwkKM11cg+s3PdrbqF95ey3WhEA4FAmZrFGYACgkQF95ey3Wh # EA7DPwf9HVwO0EO3s7OuJPBCmZBp92L6AMDBmkpnE14Pi1c4DVcWtlrBna2CNnUJ # 4Hu8rgEtT80Y8L3GBf96Wo3C1DHR6lG6dyu6FjHozWu97WfrTtw92I/254dQZnsr # i7m+5C6Tluewr9pH6ageRI0rRYt4QPpyRihMkiZQHl44Z5ogRGJvCCkjk9nIDlxi # ok2U5aPIw4NWPwnMg3wC6CmcviaM81kyuWh2Twc1OPwRilCPQXWblcUgqujg5tOr # C3Z6AwiIedpMt6Nr0jdWZh9Rh0ffuOXBEiUO/K8vYqE/eDvqJd42c8ALi1HOONoU # ZwrNWNU3o2pIQ4qz0Fs4vauK4wSs1A== # =IFN9 # -----END PGP SIGNATURE----- # gpg: Signature made Thu Jun 13 08:46:46 2024 PDT # gpg: using RSA key C2428CD75720FACDCF76B6EA17DE5ECB75A1100E # gpg: Can't check signature: No public key # Conflicts: # CHANGELOG.md # VERSION # go.mod # go.sum # vendor/golang.org/x/sys/unix/mmap_nomremap.go # vendor/golang.org/x/sys/windows/syscall_windows.go # vendor/modules.txt

v1.1.13 -- "There is no certainty in the world. This is the only certainty I have." This is the thirteenth patch release in the 1.1.z release branch of runc. It brings in Go 1.12.x compatibility and fixes a few issues, including an occasional wrong nofile rlimit in runc exec, and a race between runc list and runc delete. NOTE that if using Go 1.22.x to build runc, make sure to use 1.22.4 or a later version. For more details, see issue opencontainers#4233. * Support go 1.22.4+. (opencontainers#4313) * runc list: fix race with runc delete. (opencontainers#4231) * Fix set nofile rlimit error. (opencontainers#4277, opencontainers#4299) * libct/cg/fs: fix setting rt_period vs rt_runtime. (opencontainers#4284) * Fix a debug msg for user ns in nsexec. (opencontainers#4315) * script/*: fix gpg usage wrt keyboxd. (opencontainers#4316) * CI fixes and misc backports. (opencontainers#4241) * Fix codespell warnings. (opencontainers#4300) * Silence security false positives from golang/net. (opencontainers#4244) * libcontainer: allow containers to make apps think fips is enabled/disabled for testing. (opencontainers#4257) * allow overriding VERSION value in Makefile. (opencontainers#4270) * Vagrantfile.fedora: bump Fedora to 39. (opencontainers#4261) * ci/cirrus: rm centos stream 8. (opencontainers#4305, opencontainers#4308) Thanks to all of the contributors who made this release possible: * Akhil Mohan <akhilerm@gmail.com> * Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> * Aleksa Sarai <cyphar@cyphar.com> * Kir Kolyshkin <kolyshkin@gmail.com> * Sohan Kunkerkar <sohank2602@gmail.com> * TTFISH <jiongchiyu@gmail.com> * kychen <kychen@alauda.io> * lifubang <lifubang@acmcoder.com> * ls-ggg <335814617@qq.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> # -----BEGIN PGP SIGNATURE----- # # iQEzBAABCAAdFiEEwkKM11cg+s3PdrbqF95ey3WhEA4FAmZrFGYACgkQF95ey3Wh # EA7DPwf9HVwO0EO3s7OuJPBCmZBp92L6AMDBmkpnE14Pi1c4DVcWtlrBna2CNnUJ # 4Hu8rgEtT80Y8L3GBf96Wo3C1DHR6lG6dyu6FjHozWu97WfrTtw92I/254dQZnsr # i7m+5C6Tluewr9pH6ageRI0rRYt4QPpyRihMkiZQHl44Z5ogRGJvCCkjk9nIDlxi # ok2U5aPIw4NWPwnMg3wC6CmcviaM81kyuWh2Twc1OPwRilCPQXWblcUgqujg5tOr # C3Z6AwiIedpMt6Nr0jdWZh9Rh0ffuOXBEiUO/K8vYqE/eDvqJd42c8ALi1HOONoU # ZwrNWNU3o2pIQ4qz0Fs4vauK4wSs1A== # =IFN9 # -----END PGP SIGNATURE----- # gpg: Signature made Thu Jun 13 08:46:46 2024 PDT # gpg: using RSA key C2428CD75720FACDCF76B6EA17DE5ECB75A1100E # gpg: Can't check signature: No public key

kolyshkin added this to the 1.1.13 milestone Mar 27, 2024

kolyshkin force-pushed the 1.1-3349 branch from b6cceee to 7cf4d20 Compare March 27, 2024 23:52

kolyshkin force-pushed the 1.1-3349 branch from 7cf4d20 to 1e2342e Compare March 28, 2024 01:42

lifubang approved these changes Mar 28, 2024

View reviewed changes

kolyshkin mentioned this pull request Apr 2, 2024

[1.1] Fix setting RLIMIT_NOFILE #4239

Closed

kolyshkin changed the title ~~[1.1] runc list: fix race with runc delete~~ [1.1] runc list: fix race with runc delete; fix 1.1 CI Apr 2, 2024

kolyshkin mentioned this pull request Apr 2, 2024

[1.1] [hotfix] nsenter: refuse to build with Go 1.22 on glibc #4240

Closed

kolyshkin added the backport/1.1-pr A backport to 1.1.x release. label Apr 2, 2024

kolyshkin changed the title ~~[1.1] runc list: fix race with runc delete; fix 1.1 CI~~ [1.1] runc list: fix race with runc delete Apr 3, 2024

kolyshkin force-pushed the 1.1-3349 branch from 1e2342e to c1ee4d3 Compare April 3, 2024 04:54

kolyshkin force-pushed the 1.1-3349 branch from c1ee4d3 to dbbb29c Compare April 17, 2024 00:27

kolyshkin mentioned this pull request Apr 23, 2024

runc sometimes fails with "no such file or directory" kubernetes/minikube#17976

Closed

kolyshkin requested review from lifubang and AkihiroSuda April 26, 2024 18:16

lifubang approved these changes Apr 26, 2024

View reviewed changes

kolyshkin added 2 commits May 10, 2024 11:22

list: getContainers: less indentation

09214f2

Instead of a huge if {} block, use continue. Best reviewed with --ignore-all-space. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 095929b) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

kolyshkin force-pushed the 1.1-3349 branch from dbbb29c to 986edbe Compare May 10, 2024 18:22

AkihiroSuda approved these changes May 17, 2024

View reviewed changes

AkihiroSuda merged commit 51dc972 into opencontainers:release-1.1 May 17, 2024
29 checks passed

lifubang mentioned this pull request Jun 10, 2024

Release 1.1.13 #4318

Merged

prezha mentioned this pull request Jun 27, 2024

workaround for "runc list" returning "no such file or directory" kubernetes/minikube#17977

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.1] runc list: fix race with runc delete #4231

[1.1] runc list: fix race with runc delete #4231

kolyshkin commented Mar 27, 2024 •

edited

Loading

lifubang commented Mar 28, 2024 •

edited

Loading

kolyshkin commented Mar 28, 2024

kolyshkin commented Mar 28, 2024 •

edited

Loading

lifubang commented Mar 30, 2024

medyagh commented Apr 9, 2024

lifubang left a comment

[1.1] runc list: fix race with runc delete #4231

[1.1] runc list: fix race with runc delete #4231

Conversation

kolyshkin commented Mar 27, 2024 • edited Loading

lifubang commented Mar 28, 2024 • edited Loading

kolyshkin commented Mar 28, 2024

kolyshkin commented Mar 28, 2024 • edited Loading

lifubang commented Mar 30, 2024

medyagh commented Apr 9, 2024

lifubang left a comment

Choose a reason for hiding this comment

kolyshkin commented Mar 27, 2024 •

edited

Loading

lifubang commented Mar 28, 2024 •

edited

Loading

kolyshkin commented Mar 28, 2024 •

edited

Loading