Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/gha: switch to ubuntu 24.04 #4286

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 21, 2024

Let's replace ubuntu-22.04 with ubuntu-24.04 where we can, and keep
ubuntu-20.04 to test cgroup v1 stuff.

Leave ubuntu-22.04 for these jobs only:

  • ci/cross-i386 (issue with systemctl restart hang after apt install)
  • validate/codespell (pip install won't work) UPDATE: fixed

These issues can be addressed separately later.

The only kludge we have to add is enable userns for runc binary being
tested (as userns is disabled by apparmor system-wide by default now,
see [1]).

[1] https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#unprivileged-user-namespace-restrictions-15

@kolyshkin

This comment was marked as resolved.

@kolyshkin

This comment was marked as resolved.

@kolyshkin kolyshkin force-pushed the u24.04 branch 5 times, most recently from 56fcde7 to 7faedad Compare June 2, 2024 18:50
@kolyshkin kolyshkin marked this pull request as ready for review June 3, 2024 18:32
@kolyshkin kolyshkin changed the title [wip] ci/gha: switch to ubuntu 24.04 ci/gha: switch to ubuntu 24.04 Jun 3, 2024
@kolyshkin kolyshkin marked this pull request as draft June 3, 2024 18:34
@kolyshkin kolyshkin marked this pull request as draft June 3, 2024 18:34
@kolyshkin kolyshkin marked this pull request as draft June 3, 2024 18:34
@kolyshkin
Copy link
Contributor Author

No longer a draft; PTAL @opencontainers/runc-maintainers

Never mind

@kolyshkin kolyshkin marked this pull request as ready for review June 4, 2024 00:45
@kolyshkin kolyshkin requested review from AkihiroSuda and cyphar and removed request for AkihiroSuda June 4, 2024 00:46
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we'll have to adjust the list of required checks; perhaps to transition we should temporarily not mark 22.04 as "required" (otherwise existing PRs would never finish 🤔)

Screenshot 2024-06-04 at 08 38 29

@kolyshkin
Copy link
Contributor Author

we'll have to adjust the list of required checks; perhaps to transition we should temporarily not mark 22.04 as "required" (otherwise existing PRs would never finish 🤔)

Yes, I always take care of it once a PR (such as this one) is merged.

Let's replace ubuntu-22.04 with ubuntu-24.04 where we can, and keep
ubuntu-20.04 to test cgroup v1 stuff.

Leave ubuntu-22.04 for ci/cross-i386 (issue with systemctl restart hang
after apt install). This can be addressed separately later.

The only kludge we have to add is enable userns for runc binary being
tested (as userns is disabled by apparmor system-wide by default now,
see [1]).

[1] https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#unprivileged-user-namespace-restrictions-15

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@lifubang lifubang merged commit 7cce7e2 into opencontainers:main Jun 5, 2024
38 checks passed
@lifubang lifubang mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants