ReadMe: Update content to match print order #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Table of Contents section of the ReadMe.md to match the order of the merged MarkDown files in the printable HTML and PDF outputs Signed-off-by: Rob Dolin <RobDolin@microsoft.com> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
4288244 looks good to me.
|
|
LGTM |
1 similar comment
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Mar 10, 2016
ReadMe: Update content to match print order
Merged
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
May 19, 2016
For runtime-spec, there are often PRs that pickup and reroll another user's commits (e.g. opencontainers/runtime-spec#337). As long as the Signed-off-by entries are there (for the DCO) and the new PR references the earlier work (to avoid maintainer confusion), I see no problem with this sort of collaboration. I thought about replacing the old wording with words like the above paragraph, but it seemed overly prescriptive. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
May 23, 2016
For runtime-spec, there are often PRs that pickup and reroll another user's commits (e.g. opencontainers/runtime-spec#337). As long as the Signed-off-by entries are there (for the DCO) and the new PR references the earlier work (to avoid maintainer confusion), I see no problem with this sort of collaboration. I thought about replacing the old wording with words like the above paragraph, but it seemed overly prescriptive. Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Table of Contents section of the ReadMe.md to match the order
of the merged MarkDown files in the printable HTML and PDF outputs
Signed-off-by: Rob Dolin RobDolin@microsoft.com
Signed-off-by: Vincent Batts vbatts@hashbangbash.com