runtime: Require 'start' to validate the bundle #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec places RFC-2119 requirements on both bundles (bundle.md, config.md, ...) and runtimes (runtime.md, runtime-linux.md). While it's possible to envision a system where bundle validation is decoupled and the runtime is free to blindly stumble through as far as it can, it's likely that users will expect the runtime to perform basic bundle validatation for them. With the requirement landing in this commit, the runtime MUST at least validate bundles against this spec. The runtime MAY also validate the bundle against the host system's capabilities, but is not required to do so. Signed-off-by: W. Trevor King <wking@tremily.us>
|
-1 Every runtime author should not be expected to write validation logic for every field in the spec. Lets go with the decoupled approach. |
|
Closing since you opened the alternate approach. |
|
On Mon, May 02, 2016 at 11:16:26AM -0700, Michael Crosby wrote:
Filed in #418 for folks to compare. Once one of the PRs lands, we can |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec places RFC-2119 requirements on both bundles (bundle.md,
config.md, ...) and runtimes (runtime.md, runtime-linux.md). While
it's possible to envision a system where bundle validation is
decoupled and the runtime is free to blindly stumble through as far as
it can, it's likely that users will expect the runtime to perform
basic bundle validatation for them. With the requirement landing in
this commit, the runtime MUST at least validate bundles against this
spec. The runtime MAY also validate the bundle against the host
system's capabilities, but is not required to do so.
With this change, all RFC-2119 requirements are things the runtime is
responsible for.
I'm personally ok with the decoupled-bundle-validation approach (and
we already link to ocitools and OCT for testing both runtimes and
bundles), but figured that will be an outlier position. If we do
want to go that way (and leave runtime activity in the face of an
invalid bundle undefined), we probably want to explicitly call that
out in the ‘start’ docs to avoid surprising people.