-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux Config] Clarify which filesystem is being referenced #577
Conversation
Signed-off-by: Rob Dolin <robdolin@microsoft.com>
@@ -8,7 +8,7 @@ The Linux container specification uses various kernel features like namespaces, | |||
The Linux ABI includes both syscalls and several special file paths. | |||
Applications expecting a Linux environment will very likely expect these files paths to be setup correctly. | |||
|
|||
The following filesystems MUST be made available in each application's filesystem | |||
The following filesystems MUST be made available in each containerized application's filesystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crosbymichael pointed out a while back that we do not define “application”. Can we use “… in the container mount namespace:”? The glossary does define “container namespace”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ @crosbymichael *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just say in each container's filesystem.
@wking you are using the term incorrectly when referring to namespaces. A mount namespace is nothing more than a new mounttable for the container and is decoupled from the root filesystem.
On Tue, Sep 20, 2016 at 09:21:24AM -0700, Michael Crosby wrote:
And that mount table is where these filesystems must be available, |
Updating language as suggested by Michael Crosby in comments Signed-off-by: Rob Dolin <robdolin@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating per @crosbymichael
@RobDolinMS Could you squash the commits? |
ping @RobDolinMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any reason we can't just use GitHub's "squash-and-merge" if there's a strong preference for this to be a single commit?
Needs rebase :/ |
Signed-off-by: Rob Dolin robdolin@microsoft.com |
Replaces PR #577 Signed-off-by: Rob Dolin <robdolin@microsoft.com>
Replaced with #658. |
Replaces #577 Signed-off-by: Rob Dolin (MSFT) <robdolin@microsoft.com>
Signed-off-by: Rob Dolin robdolin@microsoft.com