runtime: Only require 'pid' in the state for created/running statuses #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because during creation (before 'created') we may not have a container process yet (e.g. if we're still reading the configuration or setting up cgroups), and in the 'stopped' phase the PID is no longer meaningful. Also add OPTIONAL/REQUIRED and remove colons for consistency with the config.md. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because during creation (before
created) we may not have a container process yet (e.g. if we're still reading the configuration or setting up cgroups), and in thestoppedphase the PID is no longer meaningful.Also add OPTIONAL/REQUIRED and remove colons for consistency with the
config.md.This documents (as best I can tell) the current semantics and gives #459 / #661 a well-defined REQUIREment to relax.
It's also the tip commit from #507 (currently at 08d52a0) cherry-picked onto master.