Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/defs-linux: Fix type for seccomp names #712

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 6, 2017

The:

"type": [
  "string"
]

syntax added in #657 is not valid:

$ ./validate ./config-schema.json <../config.json
The document is not valid. see errors :
- linux.seccomp.syscalls.0.names: Invalid type. Expected: string, given: array

The:

  "type": [
    "string"
  ]

syntax added in 652323c (improve seccomp format to be more
expressive, 2017-01-13, opencontainers#657) is not valid:

  $ ./validate ./config-schema.json <../config.json
  The document is not valid. see errors :
  - linux.seccomp.syscalls.0.names: Invalid type. Expected: string, given: array

Signed-off-by: W. Trevor King <wking@tremily.us>
@hqhq
Copy link
Contributor

hqhq commented Mar 8, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Mar 9, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 71afb41 into opencontainers:master Mar 9, 2017
@wking wking deleted the seccomp-json-schema-names branch March 13, 2017 16:21
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants