schema/Makefile: Add .PHONY declarations for phony targets #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only non-phony target (where the target name matches the output file) is 'validate', but we need .PHONY there because the Go dependencies are not represented in the Makefile. This commit adds the missing .PHONY declarations to the other targets, which truly are phony. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
|
LGTM I would prefer them in one line though. |
|
LGTM
I have the exact opposite preference 😝 I prefer PHONY to be attached to their targets. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-phony target (where the target name matches the output file) is
validate, but we need.PHONYthere because the Go dependencies are not represented in theMakefile. This commit adds the missing.PHONYdeclarations to the other targets, which truly are phony.Spun off from this discussion and following the example set by the
cleanentry in the mainMakefile.