Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle.md: specify root reference the directory #798

Merged
merged 1 commit into from
May 11, 2017

Conversation

Mashimiao
Copy link

I think this make clear what reference the directory in config.json

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com

bundle.md Outdated
@@ -16,7 +16,7 @@ See [`config.json`](config.md) for more details.

2. <a name="containerFormat02" />A directory representing the root filesystem of the container.
While the name of this REQUIRED directory may be arbitrary, users should consider using a conventional name, such as `rootfs`.
This directory MUST be referenced from within the `config.json` file.
This directory MUST be referenced by [root](config.md#root) within the `config.json` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want backticks around root to match our existing pattern.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated

I think this make clear what reference the directory in config.json

Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
@Mashimiao Mashimiao force-pushed the bundle-root-reference branch from 3dd4fc6 to 5a90133 Compare May 11, 2017 01:28
@crosbymichael
Copy link
Member

crosbymichael commented May 11, 2017

LGTM

Approved with PullApprove

@tianon
Copy link
Member

tianon commented May 11, 2017

LGTM

Approved with PullApprove

@tianon tianon merged commit 1259a08 into opencontainers:master May 11, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants