config: Remove incorrect "after the container namespaces are created" #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all hooks are run after creation. In fact, there are currently no postcreate hooks (prestart hooks are called "after the start operation is called but before the user-specified program command is executed". Fixing 28e8f68 (Hooks to linux,solaris and doc clarification, 2017-05-24, opencontainers#855), which pulled the broken line in from a Go comment [1]. [1]: opencontainers#855 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all hooks are run after creation. In fact, there are currently no
postcreatehooks (prestarthooks are called “after thestartoperation is called but before the user-specified program command is executed”. I suggest not adding this line (and removing it from the Go comment).There's an outside chance that folks could read the line as “after namespaces are created, not necessarily before
createreturns”, and that's correct. But I don't think it adds anything with each hook already clearly defining when it is triggered.Spun off from this comment.