Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use filepath instead of path #188

Merged
merged 1 commit into from
Oct 13, 2022
Merged

use filepath instead of path #188

merged 1 commit into from
Oct 13, 2022

Commits on Oct 10, 2022

  1. use filepath instead of path 

    Originally, this package was documented to be for paths separated by forward
slashes, but I was recently pointed to the updated package description, which
amended the documentation (see https://go-review.googlesource.com/32423) and
added:

> To manipulate operating system paths, use the path/filepath package.

A later patch (https://go-review.googlesource.com/45653) tweaked the description
again, adding to the `path/filepath` package:

> To process paths such as URLs that always use forward slashes regardless of
> the operating system, see the path package.

And to the `path` package

> This package does not deal with Windows paths with drive letters or backslashes;
> to manipulate operating system paths, use the path/filepath package.

I expect it to be "fine" in general to use the `path` package for Unix/Linux, but
from both patches, the intent of the Go maintainers is to use `path/filepath`
for anything file(system) related, so let's adapt to that.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    2e30223 View commit details
    Browse the repository at this point in the history