Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zstd compression #316

Closed
tych0 opened this issue Apr 20, 2020 · 3 comments · Fixed by #350
Closed

Add support for zstd compression #316

tych0 opened this issue Apr 20, 2020 · 3 comments · Fixed by #350
Labels
good first issue Easier issues for folks who are interested in contributing.
Milestone
0.5.0

Comments

@tych0
Copy link
Member

tych0 commented Apr 20, 2020

Per opencontainers/image-spec#803 using zstd compression seems to be on peoples minds.

After reading about it, it seems it's been designed with parallelism in mind, among just being faster on a single core as well. I think it would definitely speed up some of our use cases, at least.
@tych0
Copy link
Member Author

tych0 commented Apr 20, 2020

Just looking at the API, it seems like it would only take a relatively small number of changes to Mutator and the unpacking code.

@cyphar cyphar mentioned this issue Jun 23, 2020
Open
@cyphar cyphar added this to the 0.5.0 milestone Jun 23, 2020
@cyphar cyphar added the good first issue Easier issues for folks who are interested in contributing. label Jun 26, 2020
@cyphar cyphar mentioned this issue Jul 2, 2020
Open
@nishakm
Copy link

nishakm commented Nov 12, 2020

Can I try to submit a PR for this?

@tych0
Copy link
Member Author

tych0 commented Nov 12, 2020 via email

nishakm pushed a commit to nishakm/umoci that referenced this issue Nov 21, 2020
Added support for zstd compression
d405714 
Using github.com/klauspost/compress go module has brought in a
list of other compression implementations. Therefore the vendor
folder has gotten larger. Some files were also modified due to
the bump up in compress's version.

Apart from these, this commit adds an implementation for zstd
compression and a corresponding test.

Fixes opencontainers#316

Signed-off-by: Nisha K <nishak@vmware.com>
@nishakm nishakm mentioned this issue Nov 21, 2020
Merged
mateuszkwiatkowski pushed a commit to runhyve/umoci that referenced this issue Feb 4, 2021
@mateuszkwiatkowski
Added support for zstd compression
6c6008e 
Using github.com/klauspost/compress go module has brought in a
list of other compression implementations. Therefore the vendor
folder has gotten larger. Some files were also modified due to
the bump up in compress's version.

Apart from these, this commit adds an implementation for zstd
compression and a corresponding test.

Fixes opencontainers#316

Signed-off-by: Nisha K <nishak@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easier issues for folks who are interested in contributing.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Added support for zstd compression nishakm/umoci
3 participants
@tych0 @nishakm @cyphar