This repository has been archived by the owner on Sep 23, 2022. It is now read-only.
Explain how to create the hash #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, different clients may use different tags for the same referrers. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Jamstah
requested review from
dmcgowan,
imjasonh,
jdolitsky,
jonjohnsonjr,
justincormack,
lachie83,
michaelb990,
nishakm,
SteveLasker and
sudo-bmitch
as code owners
|
Not sure if this one is actually a problem, does multiple tags for the same referrer cause any issues? Also, what about the hash algorithm? Would we need that? I'm inclined to say no, for the same reason as above. |
imjasonh
approved these changes
Jul 19, 2022
|
Closing based on the vote in #65, can revisit if the plan changes again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, different clients may use different tags for the same
referrers.
Signed-off-by: James Hewitt james.hewitt@uk.ibm.com