ensure that errors are handled #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
afeld
commented
Mar 31, 2017
afeld
commented
- Run errcheck through Circle CI
- Ensure that errors are handled in code, or at least explicitly ignore them (in tests)
afeld
commented
Mar 31, 2017
lib/workspace.go
Outdated
| @@ -57,7 +58,7 @@ func LoadData(openControlDir string, certificationPath string) (common.Workspace | |||
| }(&wg) | |||
| wg.Wait() | |||
| var errs []error | |||
| // errs = append(errs, certificationErr) | |||
| errs = append(errs, certificationErr) | |||
There was a problem hiding this comment.
Hmm, this seems to be causing the build failure... @jcscottiii Happen to remember why it was commented out?
There was a problem hiding this comment.
ahh we need to do a check if certificationErr is not nil. if so, append it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.