Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GO stdlib errors instead of vektra errors #325

Merged
merged 2 commits into from
Aug 3, 2018

Conversation

redhatrises
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files          38       38           
  Lines        1428     1428           
=======================================
  Hits         1129     1129           
  Misses        246      246           
  Partials       53       53
Impacted Files Coverage Δ
tools/mapset/map.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64e676...ce0da76. Read the comment docs.

@shawndwells
Copy link
Member

Good to see standard errors being used vs 3rd party plugins! Thanks for this!

Looks good once merge conflicts taken care of.

@shawndwells shawndwells merged commit 1b29763 into opencontrol:master Aug 3, 2018
@redhatrises redhatrises deleted the remove_vektra_errors branch August 3, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants