libCOMBINE: allow a COMBINE archive to be initialised using some file contents #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue214
branch
8 times, most recently
from
7877d4f
to
0a41a39
Compare
…ather than its filename. So that we can use it from JavaScript.
Rather than have both a setter and a getter. IOW, make it more Pythonic.
After having added some buffer-related methods to libCOMBINE.
... since our license key for version 5 has now expired (!!).
This is, for instance, needed when trying to download a PMR file using the http protocol. This will indeed redirect to the https version of that file.
Had forgotten to account for the fact that a file may have been created using a URL!
agarny
force-pushed
the
issue214
branch
4 times, most recently
from
1ea18c5
to
f310a08
Compare
… to a variable name.
agarny
force-pushed
the
issue214
branch
4 times, most recently
from
8fffef6
to
99a378c
Compare
This is for ISAN, so it will need to be reverted at some point.
Indeed, symbolic links were not being resolved.
agarny
force-pushed
the
issue214
branch
2 times, most recently
from
fbd0220
to
c589b78
Compare
The end user should know that a child file is managed under /some/path/file.contents.
agarny
force-pushed
the
issue214
branch
5 times, most recently
from
fbd9953
to
187ad03
Compare
We need to do that to be able to access the .ttf and .woff2 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214.