Atlas plugin with DCO commit #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameijer
reviewed
Oct 16, 2024
| requestErrors := validateRequest(req) | ||
| if len(requestErrors) > 0 { | ||
| //return empty response | ||
| return results |
|
|
||
| if err1 != nil || err2 != nil { | ||
| // If parsing fails, skip this item | ||
| continue |
There was a problem hiding this comment.
log the errors here so we at least know something is up
| // // Iterate over the UsageDetails in CostResponse | ||
| // for _, lineItem := range pendingInvoicesResponse.LineItems { | ||
| // Create a new pb.CustomCost for each LineItem | ||
| //log.Debugf("Line item %v", item) |
| log.Debugf("Line Item %s %s", startDate.UTC(), endDate.UTC()) | ||
| // Check if the item's StartDate >= win.start and EndDate <= win.end | ||
| if (startDate.UTC().After(winStartUTC) || startDate.UTC().Equal(winStartUTC)) && | ||
| (endDate.UTC().Before(winEndUTC) || endDate.UTC().Equal(winEndUTC)) { |
|
|
||
| func (a *AtlasCostSource) getAtlasCostsForWindow(win *opencost.Window, lineItems []atlasplugin.LineItem) (*pb.CustomCostResponse, error) { | ||
|
|
||
| //filter responses between |
| MagicCookieValue: "mongodb-atlas", | ||
| } | ||
|
|
||
| const costExplorerPendingInvoices = "https://cloud.mongodb.com/api/atlas/v2/orgs/%s/invoices/pending" |
There was a problem hiding this comment.
Suggested change
| const costExplorerPendingInvoices = "https://cloud.mongodb.com/api/atlas/v2/orgs/%s/invoices/pending" | |
| const costExplorerPendingInvoicesURL = "https://cloud.mongodb.com/api/atlas/v2/orgs/%s/invoices/pending" |
| } | ||
|
|
||
| func GetPendingInvoices(org string, client HTTPClient) ([]atlasplugin.LineItem, error) { | ||
| request, _ := http.NewRequest("GET", fmt.Sprintf(costExplorerPendingInvoices, org), nil) |
There was a problem hiding this comment.
Suggested change
| request, _ := http.NewRequest("GET", fmt.Sprintf(costExplorerPendingInvoices, org), nil) | |
| request, _ := http.NewRequest("GET", fmt.Sprintf(costExplorerPendingInvoicesURL, org), nil) |
| StatusCode: http.StatusOK, | ||
| Body: io.NopCloser(bytes.NewBuffer(mockResponseJson)), | ||
| }, nil | ||
| }, |
ameijer
approved these changes
Oct 16, 2024
Closed
Merged
This was referenced Oct 17, 2024
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kal.com>
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?