Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update oci source label #18

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

MindTooth
Copy link
Contributor

What does this PR change?

Set the OCI source label to this repo.

Does this PR relate to any other PRs?

N/A.

How will this PR impact users?

Since I've worked on this for Renovate, people might loose grouping of this and normal opencost image. However, I plan to push an update to Renovate as well to fix this.

Does this PR address any GitHub or Zendesk issues?

N/A.

How was this PR tested?

docker build -t opencost-ui .
docker inspect opencost-ui
            "Labels": {
                "maintainer": "NGINX Docker Maintainers <docker-maint@nginx.com>",
                "org.opencontainers.image.description": "Cross-cloud cost allocation models for Kubernetes workloads",
                "org.opencontainers.image.documentation": "https://opencost.io/docs/",
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.source": "https://github.com/opencost/opencost-ui",
                "org.opencontainers.image.title": "opencost-ui",
                "org.opencontainers.image.url": "https://opencost.io"
            },

Does this PR require changes to documentation?

N/A.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

N/A.

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 7:13pm

Signed-off-by: Birger J. Nordølum <contact@mindtooth.no>
@MindTooth
Copy link
Contributor Author

MindTooth commented Jun 8, 2024

This is still Apache 2.0 right?


Ed1t: just a quick question, will there ever be tagged releases of this project that is the same as opencost/opencost? I see perhaps now that changing this might break getting changelogs as Renovate will be unable to compare releases. 🤔

@mattray
Copy link
Collaborator

mattray commented Jun 11, 2024

This is still Apache 2.0 right?

Ed1t: just a quick question, will there ever be tagged releases of this project that is the same as opencost/opencost? I see perhaps now that changing this might break getting changelogs as Renovate will be unable to compare releases. 🤔

Yes it is still Apache 2.0, I've opened this PR for it: #19

The plan is to continue to tag and release in sync with opencost/opencost releases

@mattray mattray merged commit 756f1eb into opencost:main Jun 11, 2024
4 checks passed
@MindTooth
Copy link
Contributor Author

Thanks.

I plan to submit a PR for a replacement with Renovate to rewrite from quay.io to ghcr.io. However, as I see it, that is only applicable for the opencost-ui and not the cost model as it's used by kubecost too?

    {
      "matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
      "replacementName": "ghcr.io/opencost/opencost-ui",
      "replacementVersion": "1.109.0"
    }

@MindTooth
Copy link
Contributor Author

Now added to Renovate 37.401.6. 🥳

@MindTooth MindTooth deleted the fix/update_oci_source_label branch June 11, 2024 10:46
@mattray
Copy link
Collaborator

mattray commented Jun 11, 2024

Thanks.

I plan to submit a PR for a replacement with Renovate to rewrite from quay.io to ghcr.io. However, as I see it, that is only applicable for the opencost-ui and not the cost model as it's used by kubecost too?

We officially switched OpenCost from quay.io to ghcr.io with the 1.109.0 release, but packages are still being published on quay.io for folks who haven't switched over yet. opencost-ui won't be published to quay.io.

@MindTooth
Copy link
Contributor Author

Having a replacement for quay.io/repository/kubecost1/kubecost-cost-model to ghcr.io/opencost/opencost will not be correct as older versions of kubecost also uses/used it?

Btw., publishing to quay has been disabled for a while now. At least it’s commented out in the workflow for build-publish.

@mattray
Copy link
Collaborator

mattray commented Jun 11, 2024 via email

@MindTooth
Copy link
Contributor Author

So, to close this.

Are you okay with a Renovate replacement for kubecost-cost-model too? Meaning, we will have the following:

    {
      "matchPackageNames": ["quay.io/kubecost1/kubecost-cost-model"],
      "replacementName": "ghcr.io/opencost/opencost",
      "replacementVersion": "1.109.0"
    },
    {
      "matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
      "replacementName": "ghcr.io/opencost/opencost-ui",
      "replacementVersion": "1.109.0"
    }

That way, when Renovate is used, we can help people move over to the correct registry/image. replacementVersion must be the oldest know version that uses the new location.

@mattray
Copy link
Collaborator

mattray commented Jun 11, 2024

That looks good except opencost-ui was just moved, so you would want the replacementVersion to be "1.110.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants