Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md translated to English #149

Merged
merged 1 commit into from
Mar 21, 2020
Merged

README.md translated to English #149

merged 1 commit into from
Mar 21, 2020

Conversation

Bost
Copy link

@Bost Bost commented Mar 19, 2020

Consider having README.eng.md instead of in-line translation.

Copy link
Contributor

@payoto payoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation, very good idea to translate the readme.
Leavign a couple of suggestions to prove I've read it.

As you suggest in your earlier message it would be better as a standalone README.eng.md file.

README.md Outdated

## Données résultantes
## Données résultantes / Results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Données résultantes / Results
## Données résultantes / Output data files

README.md Outdated
- vérifier les [pull requests](https://github.com/opencovid19-fr/data/pulls) en faisant une [code review](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews) ([tuto vidéo](https://www.youtube.com/watch?v=HW0RPaJqm4g))
> verify the [pull requests](https://github.com/opencovid19-fr/data/pulls) by reviewing the code ([video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> verify the [pull requests](https://github.com/opencovid19-fr/data/pulls) by reviewing the code ([video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g)).
> Check the [pull requests](https://github.com/opencovid19-fr/data/pulls) by performing a [code review](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews) ([video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g)).

README.md Outdated
gueris: 40 # valeur copiée du fichier YAML précédent / recovered: value copied from the previous YAML file
deces: 10 # deaths
hospitalises: 10 # hospitalized
reanimation: 5 # reanimated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reanimation: 5 # reanimated
reanimation: 5 # critical

README.md Outdated

Le bloc `victimes` détaille les informations du bulletin concernant les personnes décédés (et non les personnes contaminées). Attention ce champ ne comptabilise pas toutes les victimes depuis le début de la crise, mais uniquement les victimes annoncées dans le bulletin. Pour chaque victime, on ajoute un tiret `-`, puis les informations sur la personne. Si aucune information, ajoutez la date du décès `- date: 2020-03-10`. Si vous disposez de plus d'information, ajoutez un tiret `-` par victime puis toutes les informations disponibles `age`, `sexe` et/ou `date` (cf. exemple ci-dessus)
> The `victims` block details the information in the bulletin concerning the deceased (and not the infected). Please note that this field does not count all the victims since the start of the crisis, but only the victims announced in the bulletin. For each victim, we add a dash `-`, then the information about the person. If you have no information, add the date of death `- date: 2020-03-10`. If you have more information, add a dash `-` per victim, then all the information available` age`, `sex` and / or` date` (see example above)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You translated the field names as well when code quoting

Suggested change
> The `victims` block details the information in the bulletin concerning the deceased (and not the infected). Please note that this field does not count all the victims since the start of the crisis, but only the victims announced in the bulletin. For each victim, we add a dash `-`, then the information about the person. If you have no information, add the date of death `- date: 2020-03-10`. If you have more information, add a dash `-` per victim, then all the information available` age`, `sex` and / or` date` (see example above)
> The `victimes` block details the information in the bulletin concerning the deceased (and not the infected). Please note that this field does not count all the victims since the start of the crisis, but only the victims announced in the bulletin. For each victim, we add a dash `-`, then the information about the person. If you have no information, add the date of death `- date: 2020-03-10`. If you have more information, add a dash `-` per victim, then all the information available` age`, `sexe` and / or` date` (see example above)

Copy link
Contributor

@Binnette Binnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bost, thank for your work. Please consider creating a README.en.md as you said. (en is the default code for english)

And add something like that in the main readme: Read this in other languages: [English](README.en.md)

@Bost
Copy link
Author

Bost commented Mar 20, 2020

As you suggest in your earlier message it would be better as a standalone README.eng.md file.

Please have a look. Merci.

@payoto payoto mentioned this pull request Mar 21, 2020

- [Santé publique France](https://www.santepubliquefrance.fr)

- Regional Health Agencies - Please take the open issues to treat ARS x date, and that this work is not done repeatedly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Regional Health Agencies - Please raise an open issue before handling ARS x date, so that the work is not done repeatedly.

README.en.md Outdated

You can volunteer on a [departmental or region level](https://lite.framacalc.org/9fl9-opencovid19-frdata-volontaires).

You can also consult the [contribution guide for all data collection projects](https://github.com/opencovid19-fr/comment-contribuer).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consult -> visit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. See below

@jdesboeufs jdesboeufs merged commit 240782f into opencovid19-fr:master Mar 21, 2020
@jdesboeufs
Copy link
Member

Thank you @Bost
Now we have to create a standardized output file, for global use :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants