Fix misconfigured alerts between Kibana ndjson & Elastalert #293
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { readdirSync, readFileSync } from 'fs' | ||
|
There was a problem hiding this comment. This now ensures the ndjson and the rule yaml files are always in sync |
||
| import yaml from 'js-yaml' | ||
| import { join } from 'path' | ||
| import { expect, it } from 'vitest' | ||
|
|
||
| function findAllValuesByKey(obj: unknown, key: string): any[] { | ||
| const result: any[] = [] | ||
|
|
||
| const recurse = (item: unknown) => { | ||
| if (Array.isArray(item)) { | ||
| for (const element of item) { | ||
| recurse(element) | ||
| } | ||
| } else if (typeof item === 'object' && item !== null) { | ||
| for (const k in item) { | ||
| if (k === key) { | ||
| result.push(item[k]) | ||
| } | ||
| recurse(item[k]) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| recurse(obj) | ||
| return result | ||
| } | ||
|
|
||
| it('all tests defined in Kibana config are also defined in Elastalert config', () => { | ||
| const allAlertNames = readFileSync( | ||
| join(__dirname, '../infrastructure/monitoring/kibana', 'config.ndjson'), | ||
| 'utf8' | ||
| ) | ||
| .split('\n') | ||
| .map((str) => JSON.parse(str)) | ||
| .filter((item) => item.type === 'alert') | ||
| .map((item) => item.attributes.name) | ||
| .sort() | ||
| .filter((value, index, self) => self.indexOf(value) === index) | ||
|
|
||
| const ruleNameFilters = readdirSync( | ||
| join(__dirname, '../infrastructure/monitoring/elastalert/rules') | ||
| ) | ||
| .map((file) => | ||
| join(__dirname, '../infrastructure/monitoring/elastalert/rules', file) | ||
| ) | ||
| .map((file) => readFileSync(file, 'utf8')) | ||
| .map((file) => yaml.load(file)) | ||
| .flatMap((rule) => findAllValuesByKey(rule, 'rule.name.keyword')) | ||
| .map((x) => x.value) | ||
| .sort() | ||
| .filter((value, index, self) => self.indexOf(value) === index) | ||
|
|
||
| expect(ruleNameFilters).toEqual(allAlertNames) | ||
| }) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an update to the auto-pr pipeline. Helps me now put this to 1.5.2 and 1.6.0