seperate aws-sdk && use new sdk #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are lots of old bugs.
current code is hard to read, need refactor |
Signed-off-by: h0hmj <h0hmjcn@gmail.com>
|
recheck |
SeanHai
reviewed
Aug 5, 2022
| AWS_SDK_OPTIONS.ioOptions.clientBootstrap_create_fn = []() { | ||
| Aws::Crt::Io::EventLoopGroup eventLoopGroup(0, 1); | ||
| Aws::Crt::Io::DefaultHostResolver defaultHostResolver( | ||
| eventLoopGroup, 8 /* maxHosts */, 300 /* maxTTL */); |
There was a problem hiding this comment.
hard code, need use form option?
SeanHai
approved these changes
Aug 5, 2022
wu-hanqing
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: h0hmj h0hmjcn@gmail.com
What problem does this PR solve?
upgrading aws-sdk-cpp version
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List