curvefs/client: add feature of warmup #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuhongsong
force-pushed
the
add_warmup
branch
2 times, most recently
from
94bdd7b
to
c570cbd
Compare
xu-chaojie
reviewed
Aug 8, 2022
|
should not pull in boost for simple problem |
wuhongsong
force-pushed
the
add_warmup
branch
7 times, most recently
from
d696e7c
to
11ae6bc
Compare
|
recheck |
wuhongsong
force-pushed
the
add_warmup
branch
2 times, most recently
from
7228204
to
457d5d0
Compare
ilixiaocui
reviewed
Aug 11, 2022
wuhongsong
force-pushed
the
add_warmup
branch
2 times, most recently
from
8953e23
to
6ae1335
Compare
xu-chaojie
reviewed
Aug 12, 2022
xu-chaojie
reviewed
Aug 12, 2022
ilixiaocui
reviewed
Aug 12, 2022
| std::string pDelimiter = "\n"; | ||
| char* pToken = nullptr; | ||
| char* pSave = nullptr; | ||
| pToken = strtok_r(const_cast<char*>(file.c_str()), |
| GetTaskFetchPool().Enqueue(task); | ||
| } | ||
|
|
||
| void FuseS3Client::travelChunk(fuse_ino_t ino, S3ChunkInfoList chunkInfo, |
There was a problem hiding this comment.
What is this function for?
There was a problem hiding this comment.
travel and download all objs belong to the chunk. and i have commnted.
| } | ||
|
|
||
| void FuseS3Client::WarmUpAllObjs( | ||
| const std::list<std::pair<std::string, uint64_t>> &prefetchObjs) { |
There was a problem hiding this comment.
These logics are very similar to FileCacheManager::PrefetchS3Objs, try to merge as much as possible
There was a problem hiding this comment.
year, there are many similars, and i have added todo.
curvefs/src/client/fuse_s3_client.h
Outdated
| @@ -92,6 +101,18 @@ class FuseS3Client : public FuseClient { | |||
| private: | |||
| // s3 adaptor | |||
| std::shared_ptr<S3ClientAdaptor> s3Adaptor_; | |||
|
|
|||
| Thread bgFetchThread_; | |||
| std::atomic<bool> bgFetchStop_; | |||
There was a problem hiding this comment.
Do not define private members and functions together; use a new class to manage them.
| }; | ||
|
|
||
| TEST_F(TestFuseS3Client, warmUp_dentryNotexist) { |
There was a problem hiding this comment.
Please make a note for the test scene
|
recheck |
ilixiaocui
approved these changes
Aug 15, 2022
|
Code still needs to be optimized |
xu-chaojie
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hzwuhongsong hzwuhongsong@corp.netease.com
Issue Number: #1802
Problem Summary:
Added warmup function, then we can warmup the file to local cache directory before we need it.