curve-fuse: only update dirty inode metadata #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hanqing
force-pushed
the
issue-1845
branch
3 times, most recently
from
df0b981
to
39033e9
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
SeanHai
reviewed
Aug 25, 2022
curvefs/src/client/inode_wrapper.cpp
Outdated
| @@ -336,19 +337,25 @@ CURVEFS_ERROR InodeWrapper::UnLinkLocked(uint64_t parent) { | |||
| auto err = FlushVolumeExtent(); | |||
| if (err != CURVEFS_ERROR::OK) { | |||
| LOG(ERROR) << "Flush volume extent failed, inodeid: " | |||
| << inode_.inodeid() << ", error: " << err; | |||
| << inode_.inodeid() << ", error: " << err; | |||
curvefs/src/client/inode_wrapper.cpp
Outdated
| << ", MetaStatusCode = " << ret | ||
| << ", MetaStatusCode_Name = " << MetaStatusCode_Name(ret) | ||
| << ", inodeid = " << inode_.inodeid(); | ||
| << ", MetaStatusCode = " << ret |
curvefs/src/client/inode_wrapper.cpp
Outdated
| @@ -358,8 +365,8 @@ CURVEFS_ERROR InodeWrapper::UnLinkLocked(uint64_t parent) { | |||
|
|
|||
| CURVEFS_ERROR | |||
| InodeWrapper::UpdateInodeStatus(InodeOpenStatusChange statusChange) { | |||
| MetaStatusCode ret = | |||
| metaClient_->UpdateInodeAttrWithOutNlink(inode_, statusChange); | |||
| MetaStatusCode ret = metaClient_->UpdateInodeAttrWithOutNlink( | |||
There was a problem hiding this comment.
UpdateInodeStatus this function is not used anymore, you can delete it.
wu-hanqing
force-pushed
the
issue-1845
branch
3 times, most recently
from
918325c
to
a65138b
Compare
|
recheck |
SeanHai
approved these changes
Aug 29, 2022
ilixiaocui
approved these changes
Sep 5, 2022
Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>
Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>
wu-hanqing
force-pushed
the
issue-1845
branch
from
a65138b
to
146a459
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hanqing Wu wuhanqing@corp.netease.com
What problem does this PR solve?
Issue Number: #1845
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List