curvefs: implement setxattr interface. #1935
Conversation
curvefs/src/client/curve_fuse_op.cpp
Outdated
| std::string xattrValue(value, size); | ||
| VLOG(9) << "FuseOpSetXattr" | ||
| << " ino " << ino << " name " << name << " value " << xattrValue | ||
| << " flags " << flags; | ||
| int code = ENOTSUP; | ||
| int code = 0; |
There was a problem hiding this comment.
code only use in if, move it in the if
| } | ||
|
|
||
| CURVEFS_ERROR ret = CURVEFS_ERROR::NODATA; | ||
| ret = CURVEFS_ERROR::NODATA; | ||
| if (xValue.length() > 0) { | ||
| if ((size == 0 && xValue.length() <= MAXXATTRLENGTH) || |
There was a problem hiding this comment.
what does size == 0 mean？
size == 0是什么意思，这时候不会出错吗？
There was a problem hiding this comment.
/**
- Get an extended attribute
- If size is zero, the size of the value should be sent with
- fuse_reply_xattr.
- If the size is non-zero, and the value fits in the buffer, the
- value should be sent with fuse_reply_buf.
- If the size is too small for the value, the ERANGE error should
- be sent.
size ==0 means you should return value's length by fuse_reply_xattr, and this flag used to get the value's length first by kernel and the real size will be set in the next request.
There was a problem hiding this comment.
if size > MAXXATTRLENGTH && xValue.length() <= MAXXATTRLENGTH
it will return out of range?
SeanHai
force-pushed
the
setxattr
branch
2 times, most recently
from
f401834
to
7ffbdfc
Compare
| CURVEFS_ERROR FuseClient::FuseOpSetXattr(fuse_req_t req, fuse_ino_t ino, | ||
| const char* name, const char* value, | ||
| size_t size, int flags) { | ||
| if (option_.disableXattr) { |
There was a problem hiding this comment.
VLOG(1) << "FuseOpSetXattr " << ****;
curvefs/src/client/fuse_client.cpp
Outdated
| } else { | ||
| ret = xattrManager_->CalAllLayerSumInfo(&inodeAttr); | ||
| } | ||
| // get summary info |
There was a problem hiding this comment.
The following conditions are different, please describe the function of this code as a whole.
|
|
||
| ::curve::common::UniqueLock lgGuard = inodeWrapper->GetUniqueLock(); | ||
| inodeWrapper->SetXattrLocked(strname, strvalue); | ||
| ret = inodeWrapper->SyncAttr(); |
There was a problem hiding this comment.
Why do you need to do sync every time here?
There was a problem hiding this comment.
The xattr will lost when cache crashed If not update the xattr to metaserver
|
recheck |
curvefs/src/client/fuse_client.cpp
Outdated
| // otherwise only recursive computation all dirs. | ||
| if (!enableSumInDir_) { | ||
| if (IsOneLayer(name)) { | ||
| ret = xattrManager_->CalOneLayerSumInfo(&inodeAttr); |
There was a problem hiding this comment.
Maybe enableSumInDir_ is more suitable as a member of xattrManager_
| LOG(ERROR) << "set xattr fail, ret = " << ret << ", inodeid = " << ino | ||
| << ", name = " << strname << ", value = " << strvalue; | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
VLOG(1) << "FuseOpSetXattr end" << ****
SeanHai
force-pushed
the
setxattr
branch
3 times, most recently
from
37da493
to
66c7e38
Compare
Signed-off-by: wanghai01 <seanhaizi@163.com>
Signed-off-by: wanghai01 seanhaizi@163.com
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List