Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skipci]add delete impl #2088

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

shentupenghui
Copy link
Contributor

Signed-off-by: 申屠鹏会 shentupenghui@gmail.com

What problem does this PR solve?

Issue Number: #2030

Problem Summary:

What is changed and how it works?

What's Changed:
Add delete command in tools-v2

How it Works:
image

Side effects(Breaking backward compatibility? Performance regression?):
None

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

Copy link
Contributor

@Cyber-SiKu Cyber-SiKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job~~

tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/delete.go Outdated Show resolved Hide resolved
@Cyber-SiKu
Copy link
Contributor

Signed-off-by: 申屠鹏会 shentupenghui@gmail.com

What problem does this PR solve?

Issue Number: #2030

Problem Summary:

What is changed and how it works?

What's Changed: Add delete command in tools-v2

How it Works: image

Side effects(Breaking backward compatibility? Performance regression?): None

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

This output indicates that you did not enter the required parameter --username.

tools-v2/pkg/config/bs.go Outdated Show resolved Hide resolved
tools-v2/pkg/config/bs.go Outdated Show resolved Hide resolved
tools-v2/pkg/config/bs.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Cyber-SiKu Cyber-SiKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilixiaocui
Copy link
Contributor

Synthesize a commit submission

@shentupenghui shentupenghui force-pushed the del-impl branch 3 times, most recently from 3c5ffed to b39facd Compare November 23, 2022 08:56
Signed-off-by: 申屠鹏会 <shentupenghui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants