Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream commit of bop_toolkit #32

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

Yadunund
Copy link
Collaborator

@Yadunund Yadunund commented Feb 3, 2025

The required change to bop_toolkit was merged: thodan/bop_toolkit#176, so we can pin the upstream commit instead.

Also added default arg val to SPLIT_TYPE without which there will be a runtime error if user does not pass -e SPLIT_TYPE=val to the docker run command.

Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund requested a review from vaheta February 3, 2025 22:44
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to get a specific version, it would be even better if it was a specific tag.

One comment on what looks like an unrelated change.

Dockerfile.tester Show resolved Hide resolved
@Yadunund Yadunund merged commit 6084b37 into main Feb 3, 2025
3 checks passed
@Yadunund Yadunund deleted the yadu/switch_bop_toolkit branch February 3, 2025 23:25
Yadunund added a commit that referenced this pull request Feb 3, 2025
Signed-off-by: Yadunund <yadunund@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants