Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffmpeg osx #25

Closed
wants to merge 5 commits into from
Closed

Ffmpeg osx #25

wants to merge 5 commits into from

Conversation

cancan101
Copy link

@cancan101 cancan101 commented Feb 5, 2017

This might fix #14 on OS X for Python 2.x by using the brew install for opencv which links against ffmpeg.

@skvark
Copy link
Member

skvark commented Feb 20, 2017

I'm sorry but I can't accept this pull request. Installing OpenCV via homebrew hides the actual build process. Some main issues:

  • the build process must be consistent on all Python versions and on all platforms
    • -> cmake and given flags must be visible so that possible issues can be debugged
  • build output is not visible

Additionally some tests should be run to make sure that the video functionality works. I'm not sure if OpenCV requires the exactly same FFmpeg version as it was built with in the end user system. If that's the case, it gets more complicated to ship a wheel which works directly out of the box.

@cancan101
Copy link
Author

That's fine, I consider this more a PoC. Question is whether there are any flags used in the homebrew build that can be pulled over to your current build process to cause opencv to link against ffmpeg, etc.

@skvark
Copy link
Member

skvark commented Feb 20, 2017

Yes, I'll have to check that. I hope I have soon enough spare time to look at this FFmpeg issue. I'll leave this PR open for future reference.

@cancan101 cancan101 closed this Oct 6, 2017
@cancan101 cancan101 deleted the ffmpeg-osx branch October 6, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to open capture device (Linux and macOS builds are not compiled with FFmpeg)
2 participants